Adding default reviewers to Github repository
I followed the instructions here https://help.github.com/articles/about-codeowners/ but it doesn't seem to work. I even added the CODEOWNERS file at both the root and .github directory. The reviewers specified in the CODEOWNERS file are not selected automatically when a pull request is created. See screenshots below. Onyone who has set this up, could you point to where the problem is. Thank you.
github
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
add a comment |
I followed the instructions here https://help.github.com/articles/about-codeowners/ but it doesn't seem to work. I even added the CODEOWNERS file at both the root and .github directory. The reviewers specified in the CODEOWNERS file are not selected automatically when a pull request is created. See screenshots below. Onyone who has set this up, could you point to where the problem is. Thank you.
github
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
add a comment |
I followed the instructions here https://help.github.com/articles/about-codeowners/ but it doesn't seem to work. I even added the CODEOWNERS file at both the root and .github directory. The reviewers specified in the CODEOWNERS file are not selected automatically when a pull request is created. See screenshots below. Onyone who has set this up, could you point to where the problem is. Thank you.
github
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
I followed the instructions here https://help.github.com/articles/about-codeowners/ but it doesn't seem to work. I even added the CODEOWNERS file at both the root and .github directory. The reviewers specified in the CODEOWNERS file are not selected automatically when a pull request is created. See screenshots below. Onyone who has set this up, could you point to where the problem is. Thank you.
github
github
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
asked Nov 14 '18 at 3:33
PratheepPratheep
567312
567312
add a comment |
add a comment |
2 Answers
2
active
oldest
votes
Double-check the CODEOWNER file syntax
The pattern is followed by one or more GitHub usernames or team names using the standard
@usernameor@org/team-nameformat.
(I don't see @ in your case)
You can also refer to a user by an email address that has been added to their GitHub account, for example user@example.com.
If the syntax is correct, then you can contact GitHub support to have them investigate.
The OP Pratheep actually find this is working:
You need the
@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR.
But once the PR is created, then you will see the reviewers in the list.
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed.
This way no one can create a PR without notifying the codeowners/default reviewers.
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
I did try with with@but it didn't seem to work so it removed it. BUT in fact it works! So you need the@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR but once the PR is created then you will see the reviewers in the list.
– Pratheep
Nov 16 '18 at 3:10
@Pratheep OK, so it does work, but in a "degraded" way (the PR needs to be fully created)
– VonC
Nov 16 '18 at 5:28
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed. This way no one can create a PR without notifying the codeowners/default reviewers
– Pratheep
Nov 16 '18 at 9:31
@Pratheep Got it. I have included your comment in the answer for more visibility.
– VonC
Nov 16 '18 at 9:58
add a comment |
You need to be sure that your base branch has:
- the 'Protect this branch' flag activated
- the 'Require pull request reviews before merging' flag activated
- the 'Require review from Code Owners' flag activated
Then in the CODEOWNERS file, located either in the root of the repo or in the .github subfolder, you need to have either a user described with '@user', a user described with his email like 'user@domain.com', or a team described with '@org/teamname'.
You will need also to be sure that:
- your contributors (users and teams) have for each of them the 'write' access to the repo
- the team is not a 'secret' team, only the 'visible' teams would be taken into account
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
add a comment |
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53292809%2fadding-default-reviewers-to-github-repository%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
Double-check the CODEOWNER file syntax
The pattern is followed by one or more GitHub usernames or team names using the standard
@usernameor@org/team-nameformat.
(I don't see @ in your case)
You can also refer to a user by an email address that has been added to their GitHub account, for example user@example.com.
If the syntax is correct, then you can contact GitHub support to have them investigate.
The OP Pratheep actually find this is working:
You need the
@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR.
But once the PR is created, then you will see the reviewers in the list.
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed.
This way no one can create a PR without notifying the codeowners/default reviewers.
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
I did try with with@but it didn't seem to work so it removed it. BUT in fact it works! So you need the@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR but once the PR is created then you will see the reviewers in the list.
– Pratheep
Nov 16 '18 at 3:10
@Pratheep OK, so it does work, but in a "degraded" way (the PR needs to be fully created)
– VonC
Nov 16 '18 at 5:28
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed. This way no one can create a PR without notifying the codeowners/default reviewers
– Pratheep
Nov 16 '18 at 9:31
@Pratheep Got it. I have included your comment in the answer for more visibility.
– VonC
Nov 16 '18 at 9:58
add a comment |
Double-check the CODEOWNER file syntax
The pattern is followed by one or more GitHub usernames or team names using the standard
@usernameor@org/team-nameformat.
(I don't see @ in your case)
You can also refer to a user by an email address that has been added to their GitHub account, for example user@example.com.
If the syntax is correct, then you can contact GitHub support to have them investigate.
The OP Pratheep actually find this is working:
You need the
@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR.
But once the PR is created, then you will see the reviewers in the list.
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed.
This way no one can create a PR without notifying the codeowners/default reviewers.
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
I did try with with@but it didn't seem to work so it removed it. BUT in fact it works! So you need the@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR but once the PR is created then you will see the reviewers in the list.
– Pratheep
Nov 16 '18 at 3:10
@Pratheep OK, so it does work, but in a "degraded" way (the PR needs to be fully created)
– VonC
Nov 16 '18 at 5:28
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed. This way no one can create a PR without notifying the codeowners/default reviewers
– Pratheep
Nov 16 '18 at 9:31
@Pratheep Got it. I have included your comment in the answer for more visibility.
– VonC
Nov 16 '18 at 9:58
add a comment |
Double-check the CODEOWNER file syntax
The pattern is followed by one or more GitHub usernames or team names using the standard
@usernameor@org/team-nameformat.
(I don't see @ in your case)
You can also refer to a user by an email address that has been added to their GitHub account, for example user@example.com.
If the syntax is correct, then you can contact GitHub support to have them investigate.
The OP Pratheep actually find this is working:
You need the
@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR.
But once the PR is created, then you will see the reviewers in the list.
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed.
This way no one can create a PR without notifying the codeowners/default reviewers.
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
Double-check the CODEOWNER file syntax
The pattern is followed by one or more GitHub usernames or team names using the standard
@usernameor@org/team-nameformat.
(I don't see @ in your case)
You can also refer to a user by an email address that has been added to their GitHub account, for example user@example.com.
If the syntax is correct, then you can contact GitHub support to have them investigate.
The OP Pratheep actually find this is working:
You need the
@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR.
But once the PR is created, then you will see the reviewers in the list.
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed.
This way no one can create a PR without notifying the codeowners/default reviewers.
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
edited Nov 16 '18 at 9:57
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
answered Nov 14 '18 at 5:54
VonCVonC
840k29426563203
840k29426563203
I did try with with@but it didn't seem to work so it removed it. BUT in fact it works! So you need the@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR but once the PR is created then you will see the reviewers in the list.
– Pratheep
Nov 16 '18 at 3:10
@Pratheep OK, so it does work, but in a "degraded" way (the PR needs to be fully created)
– VonC
Nov 16 '18 at 5:28
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed. This way no one can create a PR without notifying the codeowners/default reviewers
– Pratheep
Nov 16 '18 at 9:31
@Pratheep Got it. I have included your comment in the answer for more visibility.
– VonC
Nov 16 '18 at 9:58
add a comment |
I did try with with@but it didn't seem to work so it removed it. BUT in fact it works! So you need the@and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR but once the PR is created then you will see the reviewers in the list.
– Pratheep
Nov 16 '18 at 3:10
@Pratheep OK, so it does work, but in a "degraded" way (the PR needs to be fully created)
– VonC
Nov 16 '18 at 5:28
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed. This way no one can create a PR without notifying the codeowners/default reviewers
– Pratheep
Nov 16 '18 at 9:31
@Pratheep Got it. I have included your comment in the answer for more visibility.
– VonC
Nov 16 '18 at 9:58
I did try with with
@ but it didn't seem to work so it removed it. BUT in fact it works! So you need the @ and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR but once the PR is created then you will see the reviewers in the list.– Pratheep
Nov 16 '18 at 3:10
I did try with with
@ but it didn't seem to work so it removed it. BUT in fact it works! So you need the @ and referring to my last screenshot above, you don't see the reviewers in the list when creating the PR but once the PR is created then you will see the reviewers in the list.– Pratheep
Nov 16 '18 at 3:10
@Pratheep OK, so it does work, but in a "degraded" way (the PR needs to be fully created)
– VonC
Nov 16 '18 at 5:28
@Pratheep OK, so it does work, but in a "degraded" way (the PR needs to be fully created)
– VonC
Nov 16 '18 at 5:28
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed. This way no one can create a PR without notifying the codeowners/default reviewers
– Pratheep
Nov 16 '18 at 9:31
I believe it was by design not to show. Because if you show the reviewers in that list before the PR is created, the names can be removed. This way no one can create a PR without notifying the codeowners/default reviewers
– Pratheep
Nov 16 '18 at 9:31
@Pratheep Got it. I have included your comment in the answer for more visibility.
– VonC
Nov 16 '18 at 9:58
@Pratheep Got it. I have included your comment in the answer for more visibility.
– VonC
Nov 16 '18 at 9:58
add a comment |
You need to be sure that your base branch has:
- the 'Protect this branch' flag activated
- the 'Require pull request reviews before merging' flag activated
- the 'Require review from Code Owners' flag activated
Then in the CODEOWNERS file, located either in the root of the repo or in the .github subfolder, you need to have either a user described with '@user', a user described with his email like 'user@domain.com', or a team described with '@org/teamname'.
You will need also to be sure that:
- your contributors (users and teams) have for each of them the 'write' access to the repo
- the team is not a 'secret' team, only the 'visible' teams would be taken into account
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
add a comment |
You need to be sure that your base branch has:
- the 'Protect this branch' flag activated
- the 'Require pull request reviews before merging' flag activated
- the 'Require review from Code Owners' flag activated
Then in the CODEOWNERS file, located either in the root of the repo or in the .github subfolder, you need to have either a user described with '@user', a user described with his email like 'user@domain.com', or a team described with '@org/teamname'.
You will need also to be sure that:
- your contributors (users and teams) have for each of them the 'write' access to the repo
- the team is not a 'secret' team, only the 'visible' teams would be taken into account
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
add a comment |
You need to be sure that your base branch has:
- the 'Protect this branch' flag activated
- the 'Require pull request reviews before merging' flag activated
- the 'Require review from Code Owners' flag activated
Then in the CODEOWNERS file, located either in the root of the repo or in the .github subfolder, you need to have either a user described with '@user', a user described with his email like 'user@domain.com', or a team described with '@org/teamname'.
You will need also to be sure that:
- your contributors (users and teams) have for each of them the 'write' access to the repo
- the team is not a 'secret' team, only the 'visible' teams would be taken into account
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
You need to be sure that your base branch has:
- the 'Protect this branch' flag activated
- the 'Require pull request reviews before merging' flag activated
- the 'Require review from Code Owners' flag activated
Then in the CODEOWNERS file, located either in the root of the repo or in the .github subfolder, you need to have either a user described with '@user', a user described with his email like 'user@domain.com', or a team described with '@org/teamname'.
You will need also to be sure that:
- your contributors (users and teams) have for each of them the 'write' access to the repo
- the team is not a 'secret' team, only the 'visible' teams would be taken into account
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
answered Jan 22 at 14:13
Luc DemeesterLuc Demeester
212
212
add a comment |
add a comment |
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53292809%2fadding-default-reviewers-to-github-repository%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
