Put not updating redux store
I recently upgraded to redux-saga v. 0.16.0 and it seems like actions dispatched by the saga via put aren't passed to the reducer immediately. Thus, my saga does http requests way too many times. I've read the logs and debugging shows that the put actions are bundled and dispatched in a bunch, but too late.
Any idea what I am doing wrong?
Here is some pseudo code that is pretty much the same as in production.
const shouldFetchApplications = (state, userId) =>
return !state.applications[userId].fetched
&& !state.applications[userId].fetching;
export function* fetchApplications(action)
const userId = action.userId;
const shouldFetch = yield select(shouldFetchApplications, userId);
if (shouldFetch)
yield put(actions.isFetchingApplications(userId));
try
const data = yield call(get, `/applications?userId=$userId`);
yield put(actions.applicationsFetched(data, userId));
catch (e)
console.log(e);
yield put(actions.fetchFailed(userId));
function* watchFetchApplications()
yield takeEvery(actiontypes.FETCH_APPLICATIONS_REQUESTED, fetchApplications);
export default function* applicationSagas()
yield fork(watchFetchApplications);
javascript reactjs redux redux-saga
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
add a comment |
I recently upgraded to redux-saga v. 0.16.0 and it seems like actions dispatched by the saga via put aren't passed to the reducer immediately. Thus, my saga does http requests way too many times. I've read the logs and debugging shows that the put actions are bundled and dispatched in a bunch, but too late.
Any idea what I am doing wrong?
Here is some pseudo code that is pretty much the same as in production.
const shouldFetchApplications = (state, userId) =>
return !state.applications[userId].fetched
&& !state.applications[userId].fetching;
export function* fetchApplications(action)
const userId = action.userId;
const shouldFetch = yield select(shouldFetchApplications, userId);
if (shouldFetch)
yield put(actions.isFetchingApplications(userId));
try
const data = yield call(get, `/applications?userId=$userId`);
yield put(actions.applicationsFetched(data, userId));
catch (e)
console.log(e);
yield put(actions.fetchFailed(userId));
function* watchFetchApplications()
yield takeEvery(actiontypes.FETCH_APPLICATIONS_REQUESTED, fetchApplications);
export default function* applicationSagas()
yield fork(watchFetchApplications);
javascript reactjs redux redux-saga
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
After quick look I think the code you shared is fine, I would look into the place that is dispatchingactiontypes.FETCH_APPLICATIONS_REQUESTED
– Martin Kadlec
Nov 15 '18 at 18:22
add a comment |
I recently upgraded to redux-saga v. 0.16.0 and it seems like actions dispatched by the saga via put aren't passed to the reducer immediately. Thus, my saga does http requests way too many times. I've read the logs and debugging shows that the put actions are bundled and dispatched in a bunch, but too late.
Any idea what I am doing wrong?
Here is some pseudo code that is pretty much the same as in production.
const shouldFetchApplications = (state, userId) =>
return !state.applications[userId].fetched
&& !state.applications[userId].fetching;
export function* fetchApplications(action)
const userId = action.userId;
const shouldFetch = yield select(shouldFetchApplications, userId);
if (shouldFetch)
yield put(actions.isFetchingApplications(userId));
try
const data = yield call(get, `/applications?userId=$userId`);
yield put(actions.applicationsFetched(data, userId));
catch (e)
console.log(e);
yield put(actions.fetchFailed(userId));
function* watchFetchApplications()
yield takeEvery(actiontypes.FETCH_APPLICATIONS_REQUESTED, fetchApplications);
export default function* applicationSagas()
yield fork(watchFetchApplications);
javascript reactjs redux redux-saga
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
I recently upgraded to redux-saga v. 0.16.0 and it seems like actions dispatched by the saga via put aren't passed to the reducer immediately. Thus, my saga does http requests way too many times. I've read the logs and debugging shows that the put actions are bundled and dispatched in a bunch, but too late.
Any idea what I am doing wrong?
Here is some pseudo code that is pretty much the same as in production.
const shouldFetchApplications = (state, userId) =>
return !state.applications[userId].fetched
&& !state.applications[userId].fetching;
export function* fetchApplications(action)
const userId = action.userId;
const shouldFetch = yield select(shouldFetchApplications, userId);
if (shouldFetch)
yield put(actions.isFetchingApplications(userId));
try
const data = yield call(get, `/applications?userId=$userId`);
yield put(actions.applicationsFetched(data, userId));
catch (e)
console.log(e);
yield put(actions.fetchFailed(userId));
function* watchFetchApplications()
yield takeEvery(actiontypes.FETCH_APPLICATIONS_REQUESTED, fetchApplications);
export default function* applicationSagas()
yield fork(watchFetchApplications);
javascript reactjs redux redux-saga
javascript reactjs redux redux-saga
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
edited Nov 14 '18 at 8:16
Helge
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
asked Nov 13 '18 at 15:02
HelgeHelge
37531027
37531027
After quick look I think the code you shared is fine, I would look into the place that is dispatchingactiontypes.FETCH_APPLICATIONS_REQUESTED
– Martin Kadlec
Nov 15 '18 at 18:22
add a comment |
After quick look I think the code you shared is fine, I would look into the place that is dispatchingactiontypes.FETCH_APPLICATIONS_REQUESTED
– Martin Kadlec
Nov 15 '18 at 18:22
After quick look I think the code you shared is fine, I would look into the place that is dispatching
actiontypes.FETCH_APPLICATIONS_REQUESTED– Martin Kadlec
Nov 15 '18 at 18:22
After quick look I think the code you shared is fine, I would look into the place that is dispatching
actiontypes.FETCH_APPLICATIONS_REQUESTED– Martin Kadlec
Nov 15 '18 at 18:22
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53283859%2fput-not-updating-redux-store%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53283859%2fput-not-updating-redux-store%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
After quick look I think the code you shared is fine, I would look into the place that is dispatching
actiontypes.FETCH_APPLICATIONS_REQUESTED– Martin Kadlec
Nov 15 '18 at 18:22