div slider goes beyond the borders(array length)










0















my div slider ignores the borders that i've made, can't find the mistakes.
P.S. right/left functions are called in tag attribute onclick:'slider.right()'. I'm just learning, I know that the elegance of the code is far from being ideal.



 let elArr = ;

let pusher = elArr.push(document.querySelectorAll('#scr>div'));
let elements = Array.from(elArr[0]);
let slider =
frame: 0,
set: function(element)
var container = document.getElementById('scr');
container = element.style.visibility='visible';
,

init: function()
this.set(elements[this.frame]);
,

left: function()
elements[this.frame].style.visibility='hidden';
this.frame--;
if(this.frame<0)
this.frame = elements.length - 1;
this.set(elements[this.frame]);
,

right: function()
elements[this.frame].style.visibility='hidden';
this.frame++;
if(this.frame>elements.length)
this.frame = 0;
this.set(elements[this.frame]);


;

window.onload = function()
slider.init();










share|improve this question


























    0















    my div slider ignores the borders that i've made, can't find the mistakes.
    P.S. right/left functions are called in tag attribute onclick:'slider.right()'. I'm just learning, I know that the elegance of the code is far from being ideal.



     let elArr = ;

    let pusher = elArr.push(document.querySelectorAll('#scr>div'));
    let elements = Array.from(elArr[0]);
    let slider =
    frame: 0,
    set: function(element)
    var container = document.getElementById('scr');
    container = element.style.visibility='visible';
    ,

    init: function()
    this.set(elements[this.frame]);
    ,

    left: function()
    elements[this.frame].style.visibility='hidden';
    this.frame--;
    if(this.frame<0)
    this.frame = elements.length - 1;
    this.set(elements[this.frame]);
    ,

    right: function()
    elements[this.frame].style.visibility='hidden';
    this.frame++;
    if(this.frame>elements.length)
    this.frame = 0;
    this.set(elements[this.frame]);


    ;

    window.onload = function()
    slider.init();










    share|improve this question
























      0












      0








      0








      my div slider ignores the borders that i've made, can't find the mistakes.
      P.S. right/left functions are called in tag attribute onclick:'slider.right()'. I'm just learning, I know that the elegance of the code is far from being ideal.



       let elArr = ;

      let pusher = elArr.push(document.querySelectorAll('#scr>div'));
      let elements = Array.from(elArr[0]);
      let slider =
      frame: 0,
      set: function(element)
      var container = document.getElementById('scr');
      container = element.style.visibility='visible';
      ,

      init: function()
      this.set(elements[this.frame]);
      ,

      left: function()
      elements[this.frame].style.visibility='hidden';
      this.frame--;
      if(this.frame<0)
      this.frame = elements.length - 1;
      this.set(elements[this.frame]);
      ,

      right: function()
      elements[this.frame].style.visibility='hidden';
      this.frame++;
      if(this.frame>elements.length)
      this.frame = 0;
      this.set(elements[this.frame]);


      ;

      window.onload = function()
      slider.init();










      share|improve this question














      my div slider ignores the borders that i've made, can't find the mistakes.
      P.S. right/left functions are called in tag attribute onclick:'slider.right()'. I'm just learning, I know that the elegance of the code is far from being ideal.



       let elArr = ;

      let pusher = elArr.push(document.querySelectorAll('#scr>div'));
      let elements = Array.from(elArr[0]);
      let slider =
      frame: 0,
      set: function(element)
      var container = document.getElementById('scr');
      container = element.style.visibility='visible';
      ,

      init: function()
      this.set(elements[this.frame]);
      ,

      left: function()
      elements[this.frame].style.visibility='hidden';
      this.frame--;
      if(this.frame<0)
      this.frame = elements.length - 1;
      this.set(elements[this.frame]);
      ,

      right: function()
      elements[this.frame].style.visibility='hidden';
      this.frame++;
      if(this.frame>elements.length)
      this.frame = 0;
      this.set(elements[this.frame]);


      ;

      window.onload = function()
      slider.init();







      javascript slider






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 13 '18 at 15:15









      Anton_JAnton_J

      1




      1






















          1 Answer
          1






          active

          oldest

          votes


















          0














          One great guy just helped me, so there is an incorrect condition



          if(this.frame>elements.length)


          it drops 'frame' value, when current value is bigger then the number of elements in the array, but taking in consideration the fact, that indexation of the elements starts with 0, when frame is equal to elements.length - value becomes undefined, so frame value doesn't drop.



          So, we need to change condition to a comparison == or to make it >=;
          thnx to user:186999 for the decision






          share|improve this answer






















            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "1"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53284070%2fdiv-slider-goes-beyond-the-bordersarray-length%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            0














            One great guy just helped me, so there is an incorrect condition



            if(this.frame>elements.length)


            it drops 'frame' value, when current value is bigger then the number of elements in the array, but taking in consideration the fact, that indexation of the elements starts with 0, when frame is equal to elements.length - value becomes undefined, so frame value doesn't drop.



            So, we need to change condition to a comparison == or to make it >=;
            thnx to user:186999 for the decision






            share|improve this answer



























              0














              One great guy just helped me, so there is an incorrect condition



              if(this.frame>elements.length)


              it drops 'frame' value, when current value is bigger then the number of elements in the array, but taking in consideration the fact, that indexation of the elements starts with 0, when frame is equal to elements.length - value becomes undefined, so frame value doesn't drop.



              So, we need to change condition to a comparison == or to make it >=;
              thnx to user:186999 for the decision






              share|improve this answer

























                0












                0








                0







                One great guy just helped me, so there is an incorrect condition



                if(this.frame>elements.length)


                it drops 'frame' value, when current value is bigger then the number of elements in the array, but taking in consideration the fact, that indexation of the elements starts with 0, when frame is equal to elements.length - value becomes undefined, so frame value doesn't drop.



                So, we need to change condition to a comparison == or to make it >=;
                thnx to user:186999 for the decision






                share|improve this answer













                One great guy just helped me, so there is an incorrect condition



                if(this.frame>elements.length)


                it drops 'frame' value, when current value is bigger then the number of elements in the array, but taking in consideration the fact, that indexation of the elements starts with 0, when frame is equal to elements.length - value becomes undefined, so frame value doesn't drop.



                So, we need to change condition to a comparison == or to make it >=;
                thnx to user:186999 for the decision







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered Nov 13 '18 at 19:19









                Anton_JAnton_J

                1




                1



























                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Stack Overflow!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53284070%2fdiv-slider-goes-beyond-the-bordersarray-length%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    這個網誌中的熱門文章

                    How to read a connectionString WITH PROVIDER in .NET Core?

                    Node.js Script on GitHub Pages or Amazon S3

                    Museum of Modern and Contemporary Art of Trento and Rovereto