Odtnhj

In my program, I have the user fill in various fields and choose a pokemon, and it will calculate its stats. I have the arrays under the pokemon names, and a drop down to choose which pokemon's stats to calculate. I then use eval() to change the string in the dropdown into the array's name in order to do the calculations. The full program can be found with this link

https://studio.code.org/projects/applab/8N1yw5e0CcjTik0rsmp2mgW0TSoU7DSge8k8j5mlhw0

but a simplified version is

var venusaur = [20, 10, 5, 10, 20]
var blastoise = [50, 50, 50, 10, 5]
var charizard = [100, 10, 5, 10, 100]
var mon = getText("dropdown");
findStats(eval(mon));

before I added the eval, it was much clunkier code, and would only get worse as I added more pokemon, a simpler version of which is

var venusaur = [20, 10, 5, 10, 20];
var blastoise = [50, 50, 50, 10, 5];
var charizard = [100, 10, 5, 10, 100];
if (getText(dropdown)=="venusaur")
 findStats(venusaur);
 else if (getText(dropdown)=="blastoise")
 findStats(blastoise);
 else if getText(dropdown)=="charizard")
 findStats(charizard);

I was just wondering if in this case, eval() was usable, as I've heard almost exclusively bad things about it, and I figured if there's a better way to accomplish this task, maybe I could learn it. Thanks in advance

Use an object and reference the object instead of using a bunch of global variables.

var pokes = 
 venusaur: [20, 10, 5, 10, 20],
 blastoise: [50, 50, 50, 10, 5],
 charizard: [100, 10, 5, 10, 100]

var mon = getText("dropdown");
console.log(pokes[mon])

I think you're trying to do something like that...

const stats = 
 venusaur: [20, 10, 5, 10, 20],
 blastoise: [50, 50, 50, 10, 5],
 charizard: [100, 10, 5, 10, 100],
;

const sel = document.querySelector('select');

const getStats = (e) => 'not found';


sel.addEventListener('change', getStats);

<select>
 <option value="null">Select...</option>
 <option value="venusaur">Venusaur</option>
 <option value="blastoise">Blastoise</option>
 <option value="charizard">Charizard</option>
</select>

<div id="result"></div>