i have a project of code in which i have compiled it and run it but it seems that it just return an error message like

This is my data txt file

Error Message

Can anyone help me?

#include <iostream>
#include <iomanip>
#include <string>
#include <vector>
#include <fstream>
#include <stdlib.h>
#include <sstream>
using namespace std;

struct course
 
 string CourseID;
 string CourseName;
 int CourseSemester;
 int CourseSKS;
 c;
void printMenu_course();
void printReport_course(vector <course> x, int sem);
vector <course> readData_course(int sem);
void splitData(string temp1, string temp2[4]);
int ccounter;
int sem;
int main()
 
 printMenu_course();
 return 0;


void printMenu_course()

void splitData(string temp1, string temp2[4])

 int x=0;
 string mark = ",";
 size_t pos = 0;
 while ((pos = temp1.find(mark)) != string::npos ) 
 
 temp2[x] = temp1.substr(0,pos);
 x++;
 temp1.erase(0, pos + mark.length());
 temp2[x] = temp1;



vector <course> readData_course(int sem)
 
 vector <course> x;
 ccounter = 0;
 string baris1, baris2[4];
 ifstream courFile;
 courFile.open("course.txt", ios::in);
 while(!courFile.eof())
 
 courFile >> baris1;
 splitData(baris1,baris2);
 x.push_back(course());
 x[ccounter].CourseID = baris2[0];
 x[ccounter].CourseName = baris2[1];
 x[ccounter].CourseSemester = ::atof(baris2[2].c_str());
 x[ccounter].CourseSKS = ::atof(baris2[3].c_str());
 ccounter++;
 courFile.close();
 return x; 


void printReport_course(vector<course> x, int sem)

 int num = 0;
 cout << " COURSE DATA n";
 cout << "Semester " << sem << endl;
 cout << setw(5) << "No.";
 cout << setw(5) << "Course ID";
 cout << setw(25) << "Course Name";
 cout << setw(5) << "Course SKS n";
 for(int i =0;i<ccounter;i++)
 
 if(x[i].CourseSemester == sem)
 
 cout << setw(5) << ++num;
 cout << setw(5) << x[i].CourseID;
 cout << setw(25) << x[i].CourseName;
 cout << setw(5) << x[i].CourseSKS << "n"; 
 

 

when i change the vector to only temp2[3] and baris2[3] it can run without any error but if it is temp2[4] and baris2[4] it shows an error like that again.

Reducing your program to the minimum needed to demonstrate the error and adding a couple debug statements

#include <iostream>
#include <string>
using namespace std;

void splitData(string temp1, string temp2[4])

 int x = 0;
 string mark = ",";
 size_t pos = 0;
 while ((pos = temp1.find(mark)) != string::npos)
 
 temp2[x] = temp1.substr(0, pos);
 cout << temp2[x] << ": ";
 x++;
 temp1.erase(0, pos + mark.length());
 cout << x << ": " << temp1 <<"n";
 
 if (x >= 4)
 
 cout << "Accessing temp2[x] with x = " << x << " when temp2 contains 4 elementsn";
 
 temp2[x] = temp1;


int main()

 string temp2[4];
 splitData("A,B,C,D,", temp2);

we get the following output:

A: 1: B,C,D,
B: 2: C,D,
C: 3: D,
D: 4: 
Accessing temp2[x] with x = 4 when temp2 contains 4 elements

Which clearly shows x is allowed to get out of range. Why? Count the number of items in

"A,B,C,D,"
 1 2 3 4 5

There is an empty fifth element. Luc Besson would not approve.

Solution

Remove the trailing comma in the input file.

Better Solution

Use a vector so that the number of elements doesn't matter.

#include <iostream>
#include <string>
#include <vector>
using namespace std;

vector<string> splitData(string temp1)

 vector<string> tokens;
 string mark = ",";
 size_t pos = 0;
 while ((pos = temp1.find(mark)) != string::npos)
 
 tokens.push_back(temp1.substr(0, pos));
 temp1.erase(0, pos + mark.length());
 
 tokens.push_back(temp1);
 return tokens;


int main()

 vector<string> tokens = splitData("A,B,C,D,");
 cout << "Number of tokens: " << tokens.size() << 'n';

 for (const string & token: tokens)
 
 cout << token << 'n';
 
 cout << "Done.n";

Output:

Number of tokens: 5
A
B
C
D

Done.

Unrelated comments

The naming of most of the variables is bad. string temp1 contains zero information. This makes debugging harder as you have to keep looking what the anonymous variables mean and what they are supposed to contain. Don't do this to yourself. Use descriptive names. As an added bonus the code will comment itself if the names are good enough.