Running room DB inside AsyncTask gives an error










0















Hi I am running some operation that copies data drom Firebase DB to local room DB.
Here is doInBackground part from my AsyncTask.



 @Override
protected Void doInBackground(Void... voids)

contactList = getContactListFromPhone();

DatabaseReference databaseReference = FirebaseDatabase.getInstance().getReference("users");
databaseReference.addListenerForSingleValueEvent(new ValueEventListener()
@Override
public void onDataChange(@NonNull DataSnapshot dataSnapshot)


for (DataSnapshot userSnapshot : dataSnapshot.getChildren())

User user = userSnapshot.getValue(User.class);

if (contactList.containsKey(user.getPhone()))


UserDB userDB = new UserDB();
userDB.setName(user.getName());
userDB.setPhone(user.getPhone());
userDB.setToken(user.getToken());


//adding to database
DatabaseClient.getInstance(context.getApplicationContext()).getAppDatabase().userDao().insert(userDB);




@Override
public void onCancelled(@NonNull DatabaseError databaseError)


);



return null;



But on line "DatabaseClient.getInstance...." I receiving an error:



Cannot access database on the main thread since it may potentially lock the UI for a long period of time


But I am already in AsyncTask, why is that?










share|improve this question






















  • It's not about AsyncTask but about Firebase. Firebase's onDataChange will be callen in MainThread and hence you DatabaseClient.getInstance is running in MainThread.

    – musooff
    Nov 16 '18 at 1:16















0















Hi I am running some operation that copies data drom Firebase DB to local room DB.
Here is doInBackground part from my AsyncTask.



 @Override
protected Void doInBackground(Void... voids)

contactList = getContactListFromPhone();

DatabaseReference databaseReference = FirebaseDatabase.getInstance().getReference("users");
databaseReference.addListenerForSingleValueEvent(new ValueEventListener()
@Override
public void onDataChange(@NonNull DataSnapshot dataSnapshot)


for (DataSnapshot userSnapshot : dataSnapshot.getChildren())

User user = userSnapshot.getValue(User.class);

if (contactList.containsKey(user.getPhone()))


UserDB userDB = new UserDB();
userDB.setName(user.getName());
userDB.setPhone(user.getPhone());
userDB.setToken(user.getToken());


//adding to database
DatabaseClient.getInstance(context.getApplicationContext()).getAppDatabase().userDao().insert(userDB);




@Override
public void onCancelled(@NonNull DatabaseError databaseError)


);



return null;



But on line "DatabaseClient.getInstance...." I receiving an error:



Cannot access database on the main thread since it may potentially lock the UI for a long period of time


But I am already in AsyncTask, why is that?










share|improve this question






















  • It's not about AsyncTask but about Firebase. Firebase's onDataChange will be callen in MainThread and hence you DatabaseClient.getInstance is running in MainThread.

    – musooff
    Nov 16 '18 at 1:16













0












0








0








Hi I am running some operation that copies data drom Firebase DB to local room DB.
Here is doInBackground part from my AsyncTask.



 @Override
protected Void doInBackground(Void... voids)

contactList = getContactListFromPhone();

DatabaseReference databaseReference = FirebaseDatabase.getInstance().getReference("users");
databaseReference.addListenerForSingleValueEvent(new ValueEventListener()
@Override
public void onDataChange(@NonNull DataSnapshot dataSnapshot)


for (DataSnapshot userSnapshot : dataSnapshot.getChildren())

User user = userSnapshot.getValue(User.class);

if (contactList.containsKey(user.getPhone()))


UserDB userDB = new UserDB();
userDB.setName(user.getName());
userDB.setPhone(user.getPhone());
userDB.setToken(user.getToken());


//adding to database
DatabaseClient.getInstance(context.getApplicationContext()).getAppDatabase().userDao().insert(userDB);




@Override
public void onCancelled(@NonNull DatabaseError databaseError)


);



return null;



But on line "DatabaseClient.getInstance...." I receiving an error:



Cannot access database on the main thread since it may potentially lock the UI for a long period of time


But I am already in AsyncTask, why is that?










share|improve this question














Hi I am running some operation that copies data drom Firebase DB to local room DB.
Here is doInBackground part from my AsyncTask.



 @Override
protected Void doInBackground(Void... voids)

contactList = getContactListFromPhone();

DatabaseReference databaseReference = FirebaseDatabase.getInstance().getReference("users");
databaseReference.addListenerForSingleValueEvent(new ValueEventListener()
@Override
public void onDataChange(@NonNull DataSnapshot dataSnapshot)


for (DataSnapshot userSnapshot : dataSnapshot.getChildren())

User user = userSnapshot.getValue(User.class);

if (contactList.containsKey(user.getPhone()))


UserDB userDB = new UserDB();
userDB.setName(user.getName());
userDB.setPhone(user.getPhone());
userDB.setToken(user.getToken());


//adding to database
DatabaseClient.getInstance(context.getApplicationContext()).getAppDatabase().userDao().insert(userDB);




@Override
public void onCancelled(@NonNull DatabaseError databaseError)


);



return null;



But on line "DatabaseClient.getInstance...." I receiving an error:



Cannot access database on the main thread since it may potentially lock the UI for a long period of time


But I am already in AsyncTask, why is that?







android multithreading android-room






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 15 '18 at 16:05









DimDim

1,09665497




1,09665497












  • It's not about AsyncTask but about Firebase. Firebase's onDataChange will be callen in MainThread and hence you DatabaseClient.getInstance is running in MainThread.

    – musooff
    Nov 16 '18 at 1:16

















  • It's not about AsyncTask but about Firebase. Firebase's onDataChange will be callen in MainThread and hence you DatabaseClient.getInstance is running in MainThread.

    – musooff
    Nov 16 '18 at 1:16
















It's not about AsyncTask but about Firebase. Firebase's onDataChange will be callen in MainThread and hence you DatabaseClient.getInstance is running in MainThread.

– musooff
Nov 16 '18 at 1:16





It's not about AsyncTask but about Firebase. Firebase's onDataChange will be callen in MainThread and hence you DatabaseClient.getInstance is running in MainThread.

– musooff
Nov 16 '18 at 1:16












1 Answer
1






active

oldest

votes


















1














It's not about AsyncTask but about Firebase. Firebase's onDataChange will be called in the MainThread and hence you DatabaseClient.getInstance is running in the MainThread.



You don't have to perform your Firebase calls in separate thread as Firebase client deals with it. But when you get a response from Firebase, it's onDataChange will be performed in the MainThread.



I suggest you to call Firebase in the MainThread and then after getting the data in onDataChanged, call your AsyncTask that has calls DatabaseClient.getInstance.






share|improve this answer






















    Your Answer






    StackExchange.ifUsing("editor", function ()
    StackExchange.using("externalEditor", function ()
    StackExchange.using("snippets", function ()
    StackExchange.snippets.init();
    );
    );
    , "code-snippets");

    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "1"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader:
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    ,
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );













    draft saved

    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53323423%2frunning-room-db-inside-asynctask-gives-an-error%23new-answer', 'question_page');

    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    1














    It's not about AsyncTask but about Firebase. Firebase's onDataChange will be called in the MainThread and hence you DatabaseClient.getInstance is running in the MainThread.



    You don't have to perform your Firebase calls in separate thread as Firebase client deals with it. But when you get a response from Firebase, it's onDataChange will be performed in the MainThread.



    I suggest you to call Firebase in the MainThread and then after getting the data in onDataChanged, call your AsyncTask that has calls DatabaseClient.getInstance.






    share|improve this answer



























      1














      It's not about AsyncTask but about Firebase. Firebase's onDataChange will be called in the MainThread and hence you DatabaseClient.getInstance is running in the MainThread.



      You don't have to perform your Firebase calls in separate thread as Firebase client deals with it. But when you get a response from Firebase, it's onDataChange will be performed in the MainThread.



      I suggest you to call Firebase in the MainThread and then after getting the data in onDataChanged, call your AsyncTask that has calls DatabaseClient.getInstance.






      share|improve this answer

























        1












        1








        1







        It's not about AsyncTask but about Firebase. Firebase's onDataChange will be called in the MainThread and hence you DatabaseClient.getInstance is running in the MainThread.



        You don't have to perform your Firebase calls in separate thread as Firebase client deals with it. But when you get a response from Firebase, it's onDataChange will be performed in the MainThread.



        I suggest you to call Firebase in the MainThread and then after getting the data in onDataChanged, call your AsyncTask that has calls DatabaseClient.getInstance.






        share|improve this answer













        It's not about AsyncTask but about Firebase. Firebase's onDataChange will be called in the MainThread and hence you DatabaseClient.getInstance is running in the MainThread.



        You don't have to perform your Firebase calls in separate thread as Firebase client deals with it. But when you get a response from Firebase, it's onDataChange will be performed in the MainThread.



        I suggest you to call Firebase in the MainThread and then after getting the data in onDataChanged, call your AsyncTask that has calls DatabaseClient.getInstance.







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 16 '18 at 1:19









        musooffmusooff

        593214




        593214





























            draft saved

            draft discarded
















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53323423%2frunning-room-db-inside-asynctask-gives-an-error%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            這個網誌中的熱門文章

            Barbados

            How to read a connectionString WITH PROVIDER in .NET Core?

            Node.js Script on GitHub Pages or Amazon S3