Rails 5.2 cache key for relations generating two queries









up vote
1
down vote

favorite












I have a view using fragment caching for an ActiveRecord relation, e.g.



<% cache MyModel.all do %>
...
<% end %>


I see two DB queries generated in this case



  1. SELECT COUNT(*) AS "size", MAX("my_model"."updated_at") AS timestamp FROM "my_model"

  2. SELECT "my_model".* from "my_model"

I expect the first one, and it's usually a much more efficient query. I did not expect the second one.



If I instead use:



<% cache ActiveSupport::Cache.expand_cache_key(MyModel.all) do %>
...
<% end %>


then I get only the first query with the same resulting cache key.



Is it a bug or am I doing something wrong?



EDIT: narrowed down to where this happens: see https://github.com/rails/rails/pull/29092#issuecomment-437572543




when
normalize_version
is executed, the relation does not respond to cache_version, and
therefore ends up being expanded with
to_a.
So essentially, calling Product.all.to_a and then for each object
calling cache_version, which returns nil.







ruby-on-rails caching activerecord activesupport







share|improve this question



























    up vote
    1
    down vote

    favorite












    I have a view using fragment caching for an ActiveRecord relation, e.g.



    <% cache MyModel.all do %>
    ...
    <% end %>


    I see two DB queries generated in this case



    1. SELECT COUNT(*) AS "size", MAX("my_model"."updated_at") AS timestamp FROM "my_model"

    2. SELECT "my_model".* from "my_model"

    I expect the first one, and it's usually a much more efficient query. I did not expect the second one.



    If I instead use:



    <% cache ActiveSupport::Cache.expand_cache_key(MyModel.all) do %>
    ...
    <% end %>


    then I get only the first query with the same resulting cache key.



    Is it a bug or am I doing something wrong?



    EDIT: narrowed down to where this happens: see https://github.com/rails/rails/pull/29092#issuecomment-437572543




    when
    normalize_version
    is executed, the relation does not respond to cache_version, and
    therefore ends up being expanded with
    to_a.
    So essentially, calling Product.all.to_a and then for each object
    calling cache_version, which returns nil.







    ruby-on-rails caching activerecord activesupport







    share|improve this question

























      up vote
      1
      down vote

      favorite









      up vote
      1
      down vote

      favorite











      I have a view using fragment caching for an ActiveRecord relation, e.g.



      <% cache MyModel.all do %>
      ...
      <% end %>


      I see two DB queries generated in this case



      1. SELECT COUNT(*) AS "size", MAX("my_model"."updated_at") AS timestamp FROM "my_model"

      2. SELECT "my_model".* from "my_model"

      I expect the first one, and it's usually a much more efficient query. I did not expect the second one.



      If I instead use:



      <% cache ActiveSupport::Cache.expand_cache_key(MyModel.all) do %>
      ...
      <% end %>


      then I get only the first query with the same resulting cache key.



      Is it a bug or am I doing something wrong?



      EDIT: narrowed down to where this happens: see https://github.com/rails/rails/pull/29092#issuecomment-437572543




      when
      normalize_version
      is executed, the relation does not respond to cache_version, and
      therefore ends up being expanded with
      to_a.
      So essentially, calling Product.all.to_a and then for each object
      calling cache_version, which returns nil.







      ruby-on-rails caching activerecord activesupport







      share|improve this question















      I have a view using fragment caching for an ActiveRecord relation, e.g.



      <% cache MyModel.all do %>
      ...
      <% end %>


      I see two DB queries generated in this case



      1. SELECT COUNT(*) AS "size", MAX("my_model"."updated_at") AS timestamp FROM "my_model"

      2. SELECT "my_model".* from "my_model"

      I expect the first one, and it's usually a much more efficient query. I did not expect the second one.



      If I instead use:



      <% cache ActiveSupport::Cache.expand_cache_key(MyModel.all) do %>
      ...
      <% end %>


      then I get only the first query with the same resulting cache key.



      Is it a bug or am I doing something wrong?



      EDIT: narrowed down to where this happens: see https://github.com/rails/rails/pull/29092#issuecomment-437572543




      when
      normalize_version
      is executed, the relation does not respond to cache_version, and
      therefore ends up being expanded with
      to_a.
      So essentially, calling Product.all.to_a and then for each object
      calling cache_version, which returns nil.







      ruby-on-rails caching activerecord activesupport




      ruby-on-rails caching activerecord activesupport






      share|improve this question















      share|improve this question













      share|improve this question




      share|improve this question








      edited 2 days ago

























      asked Nov 9 at 8:59









      gingerlime

      2,99432456




      2,99432456



























          active

          oldest

          votes











          Your Answer






          StackExchange.ifUsing("editor", function ()
          StackExchange.using("externalEditor", function ()
          StackExchange.using("snippets", function ()
          StackExchange.snippets.init();
          );
          );
          , "code-snippets");

          StackExchange.ready(function()
          var channelOptions =
          tags: "".split(" "),
          id: "1"
          ;
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function()
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled)
          StackExchange.using("snippets", function()
          createEditor();
          );

          else
          createEditor();

          );

          function createEditor()
          StackExchange.prepareEditor(
          heartbeatType: 'answer',
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader:
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          ,
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          );



          );













           

          draft saved


          draft discarded


















          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53222582%2frails-5-2-cache-key-for-relations-generating-two-queries%23new-answer', 'question_page');

          );

          Post as a guest






















          active

          oldest

          votes













          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes















           

          draft saved


          draft discarded















































           


          draft saved


          draft discarded














          StackExchange.ready(
          function ()
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53222582%2frails-5-2-cache-key-for-relations-generating-two-queries%23new-answer', 'question_page');

          );

          Post as a guest

































































          -

          這個網誌中的熱門文章

          How to read a connectionString WITH PROVIDER in .NET Core?

          圖片
          6 I added .AddJsonFile("Connections.json", optional: true, reloadOnChange: true) in public Startup(IHostingEnvironment env) Connections.json contains: "ConnectionStrings": "DefaultConnection": "Server=(localdb)\mssqllocaldb;Database=DATABASE;Trusted_Connection=True;MultipleActiveResultSets=true", "COR-W81-101": "Data Source=DATASOURCE;Initial Catalog=P61_CAFM_Basic;User Id=USERID;Password=PASSWORD;Persist Security Info=False;MultipleActiveResultSets=False;Packet Size=4096;", "COR-W81-100": "Data Source=DATASOURCE;Initial Catalog=Post_PS;User Id=USERID;Password=PASSWORD;Persist Security Info=False;MultipleActiveResultSets=False;Packet Size=4096;", "MSEDGEWIN10": "Data Source=DATASOURCE; Initial Catalog=COR_Basic; Persist Security Info=False;Integrated Security=true;MultipleActiveResultSets=False;Packet Size=4096;Application Name="COR_Basic"", "server...
          閱讀完整內容

          Node.js Script on GitHub Pages or Amazon S3

          圖片
          0 I'm wondering if I can run a Node.js script in my Jekyll page from GitHub Pages or Amazon S3? I think it can't run on GitHub Pages since it doesn't support server side code. Not too sure. The code is below: var Airtable = require('airtable'); var base = new Airtable(apiKey: 'YOUR_API_KEY').base('appAnZVyYqusNPV5Q'); base('Invitee list').select( // Selecting the first 3 records in Complete list: maxRecords: 3, view: "Complete list" ).eachPage(function page(records, fetchNextPage) // This function (`page`) will get called for each page of records. records.forEach(function(record) console.log('Retrieved', record.get('Email')); ); // To fetch the next page of records, call `fetchNextPage`. // If there are more records, `page` will get called again. // If there are no more records, `done` will get called. fetchNextPage(); , function done(err) if (err) console.error(err); return; ); node.js ...
          閱讀完整內容

          Museum of Modern and Contemporary Art of Trento and Rovereto

          圖片
          Art museum in Rovereto TN, Italy Museum of Modern and Contemporary Art of Trento and Rovereto Museo d'arte moderna e contemporanea di Trento e Rovereto MART, Entrance Location Corso Angelo Bettini, 43, 38068 Rovereto TN, Italy Coordinates 45°53′38″N 11°02′42″E  /  45.8940°N 11.0450°E  / 45.8940; 11.0450 Coordinates: 45°53′38″N 11°02′42″E  /  45.8940°N 11.0450°E  / 45.8940; 11.0450 Type Art museum Director Gianfranco Maraniello Public transit access Trento train station. Taxis outside station. Website mart.trento.it The Museum of Modern and Contemporary Art of Trento and Rovereto (MART) ( Museo d'Arte Moderna e Contemporanea di Trento e Rovereto , in Italian) is a museum centre in the Italian province of Trento. The main site is in Rovereto, and contains mostly modern and contemporary artworks, including works from renowned Giorgio Morandi, Giorgio de...
          閱讀完整內容