Linux Bash Shell Script









up vote
-1
down vote

favorite












What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.



# Skript: M122_Scripts/addPerson.sh
echo "Write youre name (: end with quit"
read $Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $name >> Filelist
echo $name
read $name
fi
done









share|improve this question



















  • 1




    Add a shebang and then paste your script there: shellcheck.net
    – Cyrus
    2 days ago






  • 1




    $Name != $name
    – Cyrus
    2 days ago










  • Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
    – jww
    2 days ago










  • read $Name should be read Name (no $)
    – William Pursell
    yesterday














up vote
-1
down vote

favorite












What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.



# Skript: M122_Scripts/addPerson.sh
echo "Write youre name (: end with quit"
read $Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $name >> Filelist
echo $name
read $name
fi
done









share|improve this question



















  • 1




    Add a shebang and then paste your script there: shellcheck.net
    – Cyrus
    2 days ago






  • 1




    $Name != $name
    – Cyrus
    2 days ago










  • Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
    – jww
    2 days ago










  • read $Name should be read Name (no $)
    – William Pursell
    yesterday












up vote
-1
down vote

favorite









up vote
-1
down vote

favorite











What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.



# Skript: M122_Scripts/addPerson.sh
echo "Write youre name (: end with quit"
read $Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $name >> Filelist
echo $name
read $name
fi
done









share|improve this question















What is wrong with my script? I don't see the problem, I'm sorry I'm new into Linux Shell Scripting.



# Skript: M122_Scripts/addPerson.sh
echo "Write youre name (: end with quit"
read $Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $name >> Filelist
echo $name
read $name
fi
done






linux bash shell scripting






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 2 days ago









Cyrus

44.2k43375




44.2k43375










asked 2 days ago









blend tahiri

12




12







  • 1




    Add a shebang and then paste your script there: shellcheck.net
    – Cyrus
    2 days ago






  • 1




    $Name != $name
    – Cyrus
    2 days ago










  • Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
    – jww
    2 days ago










  • read $Name should be read Name (no $)
    – William Pursell
    yesterday












  • 1




    Add a shebang and then paste your script there: shellcheck.net
    – Cyrus
    2 days ago






  • 1




    $Name != $name
    – Cyrus
    2 days ago










  • Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
    – jww
    2 days ago










  • read $Name should be read Name (no $)
    – William Pursell
    yesterday







1




1




Add a shebang and then paste your script there: shellcheck.net
– Cyrus
2 days ago




Add a shebang and then paste your script there: shellcheck.net
– Cyrus
2 days ago




1




1




$Name != $name
– Cyrus
2 days ago




$Name != $name
– Cyrus
2 days ago












Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
– jww
2 days ago




Also see How to use Shellcheck, How to debug a bash script? (U&L.SE), How to debug a bash script? (SO), How to debug bash script? (AskU), Debugging Bash scripts, etc.
– jww
2 days ago












read $Name should be read Name (no $)
– William Pursell
yesterday




read $Name should be read Name (no $)
– William Pursell
yesterday












1 Answer
1






active

oldest

votes

















up vote
2
down vote













There are some mistakes in your script, try this:



#!/bin/bash

echo "Write youre name (: end with quit"
# wrong: read $Name
read Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $Name >> Filelist
echo $Name
# wrong: read $name
read Name
fi
done





share|improve this answer






















  • I've added the # wrong: comments for visibility of the changes
    – ssemilla
    2 days ago










  • Also, I would recommend using read -r so backslashes will show in your variable.
    – ssemilla
    2 days ago










  • [ "$Name" = "quit" ] is not wrong.
    – oguzismail
    2 days ago










  • Okay, downvote removed
    – oguzismail
    yesterday










Your Answer






StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);













 

draft saved


draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53237865%2flinux-bash-shell-script%23new-answer', 'question_page');

);

Post as a guest






























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes








up vote
2
down vote













There are some mistakes in your script, try this:



#!/bin/bash

echo "Write youre name (: end with quit"
# wrong: read $Name
read Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $Name >> Filelist
echo $Name
# wrong: read $name
read Name
fi
done





share|improve this answer






















  • I've added the # wrong: comments for visibility of the changes
    – ssemilla
    2 days ago










  • Also, I would recommend using read -r so backslashes will show in your variable.
    – ssemilla
    2 days ago










  • [ "$Name" = "quit" ] is not wrong.
    – oguzismail
    2 days ago










  • Okay, downvote removed
    – oguzismail
    yesterday














up vote
2
down vote













There are some mistakes in your script, try this:



#!/bin/bash

echo "Write youre name (: end with quit"
# wrong: read $Name
read Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $Name >> Filelist
echo $Name
# wrong: read $name
read Name
fi
done





share|improve this answer






















  • I've added the # wrong: comments for visibility of the changes
    – ssemilla
    2 days ago










  • Also, I would recommend using read -r so backslashes will show in your variable.
    – ssemilla
    2 days ago










  • [ "$Name" = "quit" ] is not wrong.
    – oguzismail
    2 days ago










  • Okay, downvote removed
    – oguzismail
    yesterday












up vote
2
down vote










up vote
2
down vote









There are some mistakes in your script, try this:



#!/bin/bash

echo "Write youre name (: end with quit"
# wrong: read $Name
read Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $Name >> Filelist
echo $Name
# wrong: read $name
read Name
fi
done





share|improve this answer














There are some mistakes in your script, try this:



#!/bin/bash

echo "Write youre name (: end with quit"
# wrong: read $Name
read Name
while true; do
if [ "$Name" = "quit" ]; then
echo "exit add person"
break
else
echo $Name >> Filelist
echo $Name
# wrong: read $name
read Name
fi
done






share|improve this answer














share|improve this answer



share|improve this answer








edited yesterday

























answered 2 days ago









ssemilla

1,731313




1,731313











  • I've added the # wrong: comments for visibility of the changes
    – ssemilla
    2 days ago










  • Also, I would recommend using read -r so backslashes will show in your variable.
    – ssemilla
    2 days ago










  • [ "$Name" = "quit" ] is not wrong.
    – oguzismail
    2 days ago










  • Okay, downvote removed
    – oguzismail
    yesterday
















  • I've added the # wrong: comments for visibility of the changes
    – ssemilla
    2 days ago










  • Also, I would recommend using read -r so backslashes will show in your variable.
    – ssemilla
    2 days ago










  • [ "$Name" = "quit" ] is not wrong.
    – oguzismail
    2 days ago










  • Okay, downvote removed
    – oguzismail
    yesterday















I've added the # wrong: comments for visibility of the changes
– ssemilla
2 days ago




I've added the # wrong: comments for visibility of the changes
– ssemilla
2 days ago












Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
2 days ago




Also, I would recommend using read -r so backslashes will show in your variable.
– ssemilla
2 days ago












[ "$Name" = "quit" ] is not wrong.
– oguzismail
2 days ago




[ "$Name" = "quit" ] is not wrong.
– oguzismail
2 days ago












Okay, downvote removed
– oguzismail
yesterday




Okay, downvote removed
– oguzismail
yesterday

















 

draft saved


draft discarded















































 


draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53237865%2flinux-bash-shell-script%23new-answer', 'question_page');

);

Post as a guest














































































這個網誌中的熱門文章

How to read a connectionString WITH PROVIDER in .NET Core?

Node.js Script on GitHub Pages or Amazon S3

Museum of Modern and Contemporary Art of Trento and Rovereto