Odtnhj

I am new at Python and have been trying to use multithreading. There already exists an in-depth comment on Stackoverflow on the topic, but I still have some questions.

The goal of my program is to create and populate an array (although I guess that technically it would have to be called a "list" in Python) and have it sorted by a "divide and conquer" algorithm. Unfortunately, the terms "list" and "array" seem to be conflated by many a user, even though they are not the same. If "array" is used in my comment, please bear in mind that I have posted different code from various resources and have, for the sake of respecting the original author/s, not changed its content.

My code for populating the list count was quite simple

#!/usr/bin/env python3
count = 
i = 149
while i >= 0:
 count.append(i)
 print(i)
 i -= 1

After that I used this very handy guide on the topic of "divide and conquer" to create two lists for sorting, which were merged later on. My main concern is now how to use those lists correctly with multithreading.

In the earlier mentioned post it was argued that, basically, just a few lines of code were needed to use multithreading:

from multiprocessing.dummy import Pool as ThreadPool 
pool = ThreadPool(4)

as well as

results = pool.starmap(function, zip(list_a, list_b))

to pass multiple lists.

I have tried to adapt the code but failed. My function's parameters are def merge(count, l, m, r) (used to divide the list count into a left and a right part) and the two temporarily created lists are called L and R.

def merge(arr, l, m, r): 
 n1 = m - l + 1
 n2 = r- m 

 # create temp arrays 
 L = [0] * (n1) 
 R = [0] * (n2) 

But every time I run the program, it just responds with the following error message:

Traceback (most recent call last):
 File "./DaCcountdownTEST.py", line 71, in <module>
 results = pool.starmap(merge,zip(L,R))
NameError: name 'L' is not defined

I don't know the cause for my problem.

Any help is greatly appreciated!

I'm not sure exactly what's going wrong with your code, but here's a complete working example of a multi-threaded version of the mergeSort code you linked to:

from multiprocessing.dummy import Pool as ThreadPool 

# Merges two subarrays of arr. 
# First subarray is arr[l..m] 
# Second subarray is arr[m+1..r] 
def merge(arr, l, m, r): 
 n1 = m - l + 1
 n2 = r- m 

 # create temp arrays 
 L = [0] * (n1) 
 R = [0] * (n2) 

 # Copy data to temp arrays L and R 
 for i in range(0 , n1): 
 L[i] = arr[l + i] 

 for j in range(0 , n2): 
 R[j] = arr[m + 1 + j] 

 # Merge the temp arrays back into arr[l..r] 
 i = 0 # Initial index of first subarray 
 j = 0 # Initial index of second subarray 
 k = l # Initial index of merged subarray 

 while i < n1 and j < n2 : 
 if L[i] <= R[j]: 
 arr[k] = L[i] 
 i += 1
 else: 
 arr[k] = R[j] 
 j += 1
 k += 1

 # Copy the remaining elements of L, if there 
 # are any 
 while i < n1: 
 arr[k] = L[i] 
 i += 1
 k += 1

 # Copy the remaining elements of R, if there 
 # are any 
 while j < n2: 
 arr[k] = R[j] 
 j += 1
 k += 1

# l is for left index and r is right index of the 
# sub-array of arr to be sorted 
def mergeSort(arr,l=0,r=None):
 if r is None:
 r = len(arr) - 1

 if l < r: 
 # Same as (l+r)/2, but avoids overflow for 
 # large l and h 
 m = (l+(r-1))//2

 # Sort first and second halves
 pool = ThreadPool(2)
 pool.starmap(mergeSort, zip((arr, arr), (l, m+1), (m, r)))
 pool.close()
 pool.join()

 merge(arr, l, m, r)

Here's a short test of the code:

arr = np.random.randint(0,100,10)
print(arr)
mergeSort(arr)
print(arr)

which produces the following output:

[93 56 55 60 0 28 17 77 84 2]
[ 0 2 17 28 55 56 60 77 84 93]

Sadly, it does seem to be quite a bit slower than the single threaded version. However, this kind of slowdown is par for the course when it comes to multithreading compute-bound tasks in Python.