JavaScript - connect four - Winner is - getelementbyid
I have made the game Connect four.
When i use an alert to show the winner, the alert box pops up before the last piece is placed. Therefore i would like to use the DOM to announce the winner.
I have made a <div id="winPlayer1">Red Wins!</div> in HTML
And my JS looks like this:
function gameOver()
if (activePlayer == 0)
document.getElementById("winPlayer1").innerHTML;
else
pdocument.getElementById("winPlayer2").innerHTML;
gameActive = false;
How do i get the message to pop up when there is a winner?
Now they are both shown on the page even when there is no winner.
javascript dom innerhtml getelementbyid
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
add a comment |
I have made the game Connect four.
When i use an alert to show the winner, the alert box pops up before the last piece is placed. Therefore i would like to use the DOM to announce the winner.
I have made a <div id="winPlayer1">Red Wins!</div> in HTML
And my JS looks like this:
function gameOver()
if (activePlayer == 0)
document.getElementById("winPlayer1").innerHTML;
else
pdocument.getElementById("winPlayer2").innerHTML;
gameActive = false;
How do i get the message to pop up when there is a winner?
Now they are both shown on the page even when there is no winner.
javascript dom innerhtml getelementbyid
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
This isn't a duplicate of that question. The problem here is 1.document.getElementById("winPlayer1").innerHTML;does absolutely nothing and 2. there's a typopdocumentwhich will cause an error.
– Chris G
Nov 14 '18 at 9:23
Thanks for spotting the typo Chris. What am i missing for this to work ?
– A.Dyr
Nov 14 '18 at 9:45
1
Here's your code as you intended it I guess (display one of two divs): jsfiddle.net/khrismuc/od4x1037 Here's another version (set text of single div): jsfiddle.net/khrismuc/bjy754cp
– Chris G
Nov 14 '18 at 9:54
Thanks a lot! @ChrisG
– A.Dyr
Nov 14 '18 at 10:28
add a comment |
I have made the game Connect four.
When i use an alert to show the winner, the alert box pops up before the last piece is placed. Therefore i would like to use the DOM to announce the winner.
I have made a <div id="winPlayer1">Red Wins!</div> in HTML
And my JS looks like this:
function gameOver()
if (activePlayer == 0)
document.getElementById("winPlayer1").innerHTML;
else
pdocument.getElementById("winPlayer2").innerHTML;
gameActive = false;
How do i get the message to pop up when there is a winner?
Now they are both shown on the page even when there is no winner.
javascript dom innerhtml getelementbyid
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
I have made the game Connect four.
When i use an alert to show the winner, the alert box pops up before the last piece is placed. Therefore i would like to use the DOM to announce the winner.
I have made a <div id="winPlayer1">Red Wins!</div> in HTML
And my JS looks like this:
function gameOver()
if (activePlayer == 0)
document.getElementById("winPlayer1").innerHTML;
else
pdocument.getElementById("winPlayer2").innerHTML;
gameActive = false;
How do i get the message to pop up when there is a winner?
Now they are both shown on the page even when there is no winner.
javascript dom innerhtml getelementbyid
javascript dom innerhtml getelementbyid
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
edited Nov 14 '18 at 9:16
Praveen Kumar Purushothaman
133k23136183
133k23136183
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
asked Nov 14 '18 at 9:15
A.DyrA.Dyr
35
35
This isn't a duplicate of that question. The problem here is 1.document.getElementById("winPlayer1").innerHTML;does absolutely nothing and 2. there's a typopdocumentwhich will cause an error.
– Chris G
Nov 14 '18 at 9:23
Thanks for spotting the typo Chris. What am i missing for this to work ?
– A.Dyr
Nov 14 '18 at 9:45
1
Here's your code as you intended it I guess (display one of two divs): jsfiddle.net/khrismuc/od4x1037 Here's another version (set text of single div): jsfiddle.net/khrismuc/bjy754cp
– Chris G
Nov 14 '18 at 9:54
Thanks a lot! @ChrisG
– A.Dyr
Nov 14 '18 at 10:28
add a comment |
This isn't a duplicate of that question. The problem here is 1.document.getElementById("winPlayer1").innerHTML;does absolutely nothing and 2. there's a typopdocumentwhich will cause an error.
– Chris G
Nov 14 '18 at 9:23
Thanks for spotting the typo Chris. What am i missing for this to work ?
– A.Dyr
Nov 14 '18 at 9:45
1
Here's your code as you intended it I guess (display one of two divs): jsfiddle.net/khrismuc/od4x1037 Here's another version (set text of single div): jsfiddle.net/khrismuc/bjy754cp
– Chris G
Nov 14 '18 at 9:54
Thanks a lot! @ChrisG
– A.Dyr
Nov 14 '18 at 10:28
This isn't a duplicate of that question. The problem here is 1.
document.getElementById("winPlayer1").innerHTML; does absolutely nothing and 2. there's a typo pdocument which will cause an error.– Chris G
Nov 14 '18 at 9:23
This isn't a duplicate of that question. The problem here is 1.
document.getElementById("winPlayer1").innerHTML; does absolutely nothing and 2. there's a typo pdocument which will cause an error.– Chris G
Nov 14 '18 at 9:23
Thanks for spotting the typo Chris. What am i missing for this to work ?
– A.Dyr
Nov 14 '18 at 9:45
Thanks for spotting the typo Chris. What am i missing for this to work ?
– A.Dyr
Nov 14 '18 at 9:45
1
1
Here's your code as you intended it I guess (display one of two divs): jsfiddle.net/khrismuc/od4x1037 Here's another version (set text of single div): jsfiddle.net/khrismuc/bjy754cp
– Chris G
Nov 14 '18 at 9:54
Here's your code as you intended it I guess (display one of two divs): jsfiddle.net/khrismuc/od4x1037 Here's another version (set text of single div): jsfiddle.net/khrismuc/bjy754cp
– Chris G
Nov 14 '18 at 9:54
Thanks a lot! @ChrisG
– A.Dyr
Nov 14 '18 at 10:28
Thanks a lot! @ChrisG
– A.Dyr
Nov 14 '18 at 10:28
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53296610%2fjavascript-connect-four-winner-is-getelementbyid%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53296610%2fjavascript-connect-four-winner-is-getelementbyid%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
This isn't a duplicate of that question. The problem here is 1.
document.getElementById("winPlayer1").innerHTML;does absolutely nothing and 2. there's a typopdocumentwhich will cause an error.– Chris G
Nov 14 '18 at 9:23
Thanks for spotting the typo Chris. What am i missing for this to work ?
– A.Dyr
Nov 14 '18 at 9:45
1
Here's your code as you intended it I guess (display one of two divs): jsfiddle.net/khrismuc/od4x1037 Here's another version (set text of single div): jsfiddle.net/khrismuc/bjy754cp
– Chris G
Nov 14 '18 at 9:54
Thanks a lot! @ChrisG
– A.Dyr
Nov 14 '18 at 10:28