Is there an ISubscriber event for completing a Pull Request in TFS 2018?
I am working on a plugin for TFS to hook certain operations. I'm able to successfully hook code pushes via using an ISubscriber on PushNotification, but am having trouble finding any type that matches up with the completion of a Pull Request.
A little more on what I'm trying to do. I currently have a PushNotification hook that has some branch specific checks that it does. Some reject a push, others provide notifications to users using some complex rules. I need a way to be able to provide the notifications at a minimum, and ideally prevent the pull request from going through. I can't provide notifications prior to the pull request going through as the notifications should only occur for code being placed in our main repository.
Long term, I want to switch it over to using the webhooks and some async approval, but I don't have the time to adapt the tools to work like that and setup the additional server needed to make that happen. If there's no good solution, I'll simply disable pull requests for now until I can write proper services for it, but if there is a way to reuse the adapted hooks that can run on the PushNotification ISubscriber, it would be extremely helpful.
tfs
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
add a comment |
I am working on a plugin for TFS to hook certain operations. I'm able to successfully hook code pushes via using an ISubscriber on PushNotification, but am having trouble finding any type that matches up with the completion of a Pull Request.
A little more on what I'm trying to do. I currently have a PushNotification hook that has some branch specific checks that it does. Some reject a push, others provide notifications to users using some complex rules. I need a way to be able to provide the notifications at a minimum, and ideally prevent the pull request from going through. I can't provide notifications prior to the pull request going through as the notifications should only occur for code being placed in our main repository.
Long term, I want to switch it over to using the webhooks and some async approval, but I don't have the time to adapt the tools to work like that and setup the additional server needed to make that happen. If there's no good solution, I'll simply disable pull requests for now until I can write proper services for it, but if there is a way to reuse the adapted hooks that can run on the PushNotification ISubscriber, it would be extremely helpful.
tfs
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
Do you want to complete pull request programmatically?
– Shayki Abramczyk
Nov 14 '18 at 20:49
No, I don't need to complete it programatically, though, that might be a viable work around if I can disable making them go through without being programmatic.The main problem is trying to make sure I run checks at the point that code hits the protected repo, not before.
– AJ Henderson
Nov 14 '18 at 22:49
add a comment |
I am working on a plugin for TFS to hook certain operations. I'm able to successfully hook code pushes via using an ISubscriber on PushNotification, but am having trouble finding any type that matches up with the completion of a Pull Request.
A little more on what I'm trying to do. I currently have a PushNotification hook that has some branch specific checks that it does. Some reject a push, others provide notifications to users using some complex rules. I need a way to be able to provide the notifications at a minimum, and ideally prevent the pull request from going through. I can't provide notifications prior to the pull request going through as the notifications should only occur for code being placed in our main repository.
Long term, I want to switch it over to using the webhooks and some async approval, but I don't have the time to adapt the tools to work like that and setup the additional server needed to make that happen. If there's no good solution, I'll simply disable pull requests for now until I can write proper services for it, but if there is a way to reuse the adapted hooks that can run on the PushNotification ISubscriber, it would be extremely helpful.
tfs
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
I am working on a plugin for TFS to hook certain operations. I'm able to successfully hook code pushes via using an ISubscriber on PushNotification, but am having trouble finding any type that matches up with the completion of a Pull Request.
A little more on what I'm trying to do. I currently have a PushNotification hook that has some branch specific checks that it does. Some reject a push, others provide notifications to users using some complex rules. I need a way to be able to provide the notifications at a minimum, and ideally prevent the pull request from going through. I can't provide notifications prior to the pull request going through as the notifications should only occur for code being placed in our main repository.
Long term, I want to switch it over to using the webhooks and some async approval, but I don't have the time to adapt the tools to work like that and setup the additional server needed to make that happen. If there's no good solution, I'll simply disable pull requests for now until I can write proper services for it, but if there is a way to reuse the adapted hooks that can run on the PushNotification ISubscriber, it would be extremely helpful.
tfs
tfs
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
edited Nov 14 '18 at 22:48
AJ Henderson
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
asked Nov 14 '18 at 19:49
AJ HendersonAJ Henderson
756727
756727
Do you want to complete pull request programmatically?
– Shayki Abramczyk
Nov 14 '18 at 20:49
No, I don't need to complete it programatically, though, that might be a viable work around if I can disable making them go through without being programmatic.The main problem is trying to make sure I run checks at the point that code hits the protected repo, not before.
– AJ Henderson
Nov 14 '18 at 22:49
add a comment |
Do you want to complete pull request programmatically?
– Shayki Abramczyk
Nov 14 '18 at 20:49
No, I don't need to complete it programatically, though, that might be a viable work around if I can disable making them go through without being programmatic.The main problem is trying to make sure I run checks at the point that code hits the protected repo, not before.
– AJ Henderson
Nov 14 '18 at 22:49
Do you want to complete pull request programmatically?
– Shayki Abramczyk
Nov 14 '18 at 20:49
Do you want to complete pull request programmatically?
– Shayki Abramczyk
Nov 14 '18 at 20:49
No, I don't need to complete it programatically, though, that might be a viable work around if I can disable making them go through without being programmatic.The main problem is trying to make sure I run checks at the point that code hits the protected repo, not before.
– AJ Henderson
Nov 14 '18 at 22:49
No, I don't need to complete it programatically, though, that might be a viable work around if I can disable making them go through without being programmatic.The main problem is trying to make sure I run checks at the point that code hits the protected repo, not before.
– AJ Henderson
Nov 14 '18 at 22:49
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");
StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);
else
createEditor();
);
function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);
);
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53307763%2fis-there-an-isubscriber-event-for-completing-a-pull-request-in-tfs-2018%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53307763%2fis-there-an-isubscriber-event-for-completing-a-pull-request-in-tfs-2018%23new-answer', 'question_page');
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Do you want to complete pull request programmatically?
– Shayki Abramczyk
Nov 14 '18 at 20:49
No, I don't need to complete it programatically, though, that might be a viable work around if I can disable making them go through without being programmatic.The main problem is trying to make sure I run checks at the point that code hits the protected repo, not before.
– AJ Henderson
Nov 14 '18 at 22:49