Odtnhj

I have a .dvb file created in VBA, I am getting a compile error stating:

variable not defined

There are two modules of code one for the form and one for common dialog. The error I am getting is for common dialog code that has been swiped from somewhere else for handling Browse and adding drawings.

Common dialog code Module extract:

 Public Function GetFiles( _
ByVal sInitFolder As String, _
ByVal sTitle As String, _
ByVal sFilter As String, _
ByVal nFilterIndex As Integer) As String()

strReturn = FileBrowseOpen(sInitFolder, sTitle, sFilter, nFilterIndex, True) 'code failing here "compile error variable not defined"
GetFiles = Split(strReturn, ",")

End Function

Form Code module extract:

Private Sub cmdAddDwg_Click()

Dim initFolder As String
Dim filter As String
Dim fileNames() As String
Dim i As Integer

initFolder = ThisDrawing.Path
filter = "AutoCAD Drawing Files (*.dwg)|*.dwg|All Files (*.*)|*.*"

fileNames = GetFiles(initFolder, "Select Drawing Files", filter, 0)
If UBound(fileNames) > 0 Then
 For i = 1 To UBound(fileNames)
 lstDwgList.AddItem fileNames(0) & "" & fileNames(i)
 Next
End If

End Sub

My VBA knowledge is limited at best.

Thanks in advance much appreciated.

Either define your variable strReturn as a string:

Public Function GetFiles ( _
 ByVal sInitFolder As String, _
 ByVal sTitle As String, _
 ByVal sFilter As String, _
 ByVal nFilterIndex As Integer) As String()

 Dim strReturn As String ' This line was missing
 strReturn = FileBrowseOpen(sInitFolder, sTitle, sFilter, nFilterIndex, True)
 GetFiles = Split(strReturn, ",")
End Function

Or rewrite that section of the code to omit the strReturn variable entirely:

Public Function GetFiles ( _
 ByVal sInitFolder As String, _
 ByVal sTitle As String, _
 ByVal sFilter As String, _
 ByVal nFilterIndex As Integer) As String()

 GetFiles = Split(FileBrowseOpen(sInitFolder, sTitle, sFilter, nFilterIndex, True), ",")
End Function

Private Sub cmdAddDwg_Click()
Dim initFolder As String
Dim filter As String
Dim fileNames() As String
Dim i As Integer

'initFolder = ThisDrawing.Path 'gets dwg folder path
initFolder = lastPath 'gets last known location
filter = "AutoCAD Drawing Files (*.dwg)|*.dwg|All Files (*.*)|*.*"

fileNames = GetFiles(initFolder, "Select Drawing Files", filter, 0)
If UBound(fileNames) > 0 Then
 For i = 1 To UBound(fileNames)
 lstDwgList.AddItem fileNames(0) & "" & fileNames(i)
 Next

End If

End Sub