Warning: A component is changing an uncontrolled input of type text to be controlled










0















The full error:
A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa)
My code:



//Form.js
componentDidMount = () =>
let state = ;
const inputProps = this.props;
//example for inputProps:
// nameInput: element: Input/*Input.js*/, value: "initial value"
//
Object.keys(inputProps).forEach(key =>
const input = inputProps[key];
const value = input;
state[key] =
...input,
value,
onChange: this.inputChange(key)

)
this.setState(state)

inputChange = key => event => this.setState(
[key]:
...this.state[key],
value: event.target.value

)
inputs = () => Object.keys(this.state).map(key =>
const input = this.state[key];
const element, typeCheck, ...props = input;
return React.createElement(element, props);
)
//Input.js
//the error comes after typeChecking in Form.js I just didn't wanted to show unnecessary code
const Input = (error, ...props) => <div className="inputContainer">
React.createElement("input", props)
<p className="inputError">error </p>
</div>


So what happens here is that I have a component Form which accepts an object as it's prop to define which inputs needed to create. When it did mount, it processes the inputs properties and sets it as it's state. It's a bit sneaky because we might get value as prop of the inputs, but we put it to the Form's state. Also, we also give the value to the Input element, so it's controlled, and if the input changes, triggers a function which is called in the Form, and set the value to it's own state, then gives the updated value back to the Input. So it seems like the input is controlled, but I still get the error. Everything works well, so the input gets the updated values, and sends the changed input, I just get the error and it's annoying.










share|improve this question






















  • Possible duplicate of React - changing an uncontrolled input

    – HMR
    Nov 16 '18 at 11:38















0















The full error:
A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa)
My code:



//Form.js
componentDidMount = () =>
let state = ;
const inputProps = this.props;
//example for inputProps:
// nameInput: element: Input/*Input.js*/, value: "initial value"
//
Object.keys(inputProps).forEach(key =>
const input = inputProps[key];
const value = input;
state[key] =
...input,
value,
onChange: this.inputChange(key)

)
this.setState(state)

inputChange = key => event => this.setState(
[key]:
...this.state[key],
value: event.target.value

)
inputs = () => Object.keys(this.state).map(key =>
const input = this.state[key];
const element, typeCheck, ...props = input;
return React.createElement(element, props);
)
//Input.js
//the error comes after typeChecking in Form.js I just didn't wanted to show unnecessary code
const Input = (error, ...props) => <div className="inputContainer">
React.createElement("input", props)
<p className="inputError">error </p>
</div>


So what happens here is that I have a component Form which accepts an object as it's prop to define which inputs needed to create. When it did mount, it processes the inputs properties and sets it as it's state. It's a bit sneaky because we might get value as prop of the inputs, but we put it to the Form's state. Also, we also give the value to the Input element, so it's controlled, and if the input changes, triggers a function which is called in the Form, and set the value to it's own state, then gives the updated value back to the Input. So it seems like the input is controlled, but I still get the error. Everything works well, so the input gets the updated values, and sends the changed input, I just get the error and it's annoying.










share|improve this question






















  • Possible duplicate of React - changing an uncontrolled input

    – HMR
    Nov 16 '18 at 11:38













0












0








0


1






The full error:
A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa)
My code:



//Form.js
componentDidMount = () =>
let state = ;
const inputProps = this.props;
//example for inputProps:
// nameInput: element: Input/*Input.js*/, value: "initial value"
//
Object.keys(inputProps).forEach(key =>
const input = inputProps[key];
const value = input;
state[key] =
...input,
value,
onChange: this.inputChange(key)

)
this.setState(state)

inputChange = key => event => this.setState(
[key]:
...this.state[key],
value: event.target.value

)
inputs = () => Object.keys(this.state).map(key =>
const input = this.state[key];
const element, typeCheck, ...props = input;
return React.createElement(element, props);
)
//Input.js
//the error comes after typeChecking in Form.js I just didn't wanted to show unnecessary code
const Input = (error, ...props) => <div className="inputContainer">
React.createElement("input", props)
<p className="inputError">error </p>
</div>


So what happens here is that I have a component Form which accepts an object as it's prop to define which inputs needed to create. When it did mount, it processes the inputs properties and sets it as it's state. It's a bit sneaky because we might get value as prop of the inputs, but we put it to the Form's state. Also, we also give the value to the Input element, so it's controlled, and if the input changes, triggers a function which is called in the Form, and set the value to it's own state, then gives the updated value back to the Input. So it seems like the input is controlled, but I still get the error. Everything works well, so the input gets the updated values, and sends the changed input, I just get the error and it's annoying.










share|improve this question














The full error:
A component is changing an uncontrolled input of type text to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa)
My code:



//Form.js
componentDidMount = () =>
let state = ;
const inputProps = this.props;
//example for inputProps:
// nameInput: element: Input/*Input.js*/, value: "initial value"
//
Object.keys(inputProps).forEach(key =>
const input = inputProps[key];
const value = input;
state[key] =
...input,
value,
onChange: this.inputChange(key)

)
this.setState(state)

inputChange = key => event => this.setState(
[key]:
...this.state[key],
value: event.target.value

)
inputs = () => Object.keys(this.state).map(key =>
const input = this.state[key];
const element, typeCheck, ...props = input;
return React.createElement(element, props);
)
//Input.js
//the error comes after typeChecking in Form.js I just didn't wanted to show unnecessary code
const Input = (error, ...props) => <div className="inputContainer">
React.createElement("input", props)
<p className="inputError">error </p>
</div>


So what happens here is that I have a component Form which accepts an object as it's prop to define which inputs needed to create. When it did mount, it processes the inputs properties and sets it as it's state. It's a bit sneaky because we might get value as prop of the inputs, but we put it to the Form's state. Also, we also give the value to the Input element, so it's controlled, and if the input changes, triggers a function which is called in the Form, and set the value to it's own state, then gives the updated value back to the Input. So it seems like the input is controlled, but I still get the error. Everything works well, so the input gets the updated values, and sends the changed input, I just get the error and it's annoying.







javascript reactjs






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 14 '18 at 12:17









Gergő HorváthGergő Horváth

504113




504113












  • Possible duplicate of React - changing an uncontrolled input

    – HMR
    Nov 16 '18 at 11:38

















  • Possible duplicate of React - changing an uncontrolled input

    – HMR
    Nov 16 '18 at 11:38
















Possible duplicate of React - changing an uncontrolled input

– HMR
Nov 16 '18 at 11:38





Possible duplicate of React - changing an uncontrolled input

– HMR
Nov 16 '18 at 11:38












1 Answer
1






active

oldest

votes


















2














If the input value is initialized as null or undefined you'll always get this error. You can avoid it by setting the input value to an empty string.






share|improve this answer






















    Your Answer






    StackExchange.ifUsing("editor", function ()
    StackExchange.using("externalEditor", function ()
    StackExchange.using("snippets", function ()
    StackExchange.snippets.init();
    );
    );
    , "code-snippets");

    StackExchange.ready(function()
    var channelOptions =
    tags: "".split(" "),
    id: "1"
    ;
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function()
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled)
    StackExchange.using("snippets", function()
    createEditor();
    );

    else
    createEditor();

    );

    function createEditor()
    StackExchange.prepareEditor(
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader:
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    ,
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    );



    );













    draft saved

    draft discarded


















    StackExchange.ready(
    function ()
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53300072%2fwarning-a-component-is-changing-an-uncontrolled-input-of-type-text-to-be-contro%23new-answer', 'question_page');

    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    2














    If the input value is initialized as null or undefined you'll always get this error. You can avoid it by setting the input value to an empty string.






    share|improve this answer



























      2














      If the input value is initialized as null or undefined you'll always get this error. You can avoid it by setting the input value to an empty string.






      share|improve this answer

























        2












        2








        2







        If the input value is initialized as null or undefined you'll always get this error. You can avoid it by setting the input value to an empty string.






        share|improve this answer













        If the input value is initialized as null or undefined you'll always get this error. You can avoid it by setting the input value to an empty string.







        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 14 '18 at 12:20









        Josef FazekasJosef Fazekas

        30026




        30026





























            draft saved

            draft discarded
















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid


            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.

            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53300072%2fwarning-a-component-is-changing-an-uncontrolled-input-of-type-text-to-be-contro%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            這個網誌中的熱門文章

            Barbados

            How to read a connectionString WITH PROVIDER in .NET Core?

            Node.js Script on GitHub Pages or Amazon S3