Odtnhj

I'm trying to write a mixin that will protect views by first checking if someone is logged in and then if they have been onboarded. It seems to work, by blocking views it's attached to, but it the URLjust goes to a 403 forbidden. Any ideas on how to get it to go to the named url?

from django.contrib.auth.mixins import UserPassesTestMixin
from django.http import HttpResponseRedirect
from django.shortcuts import redirect
from django.contrib.auth.mixins import LoginRequiredMixin


class OnboardedMixin(LoginRequiredMixin, UserPassesTestMixin):
 """
 a custom mixin that checks to see if the user has been onboarded yet
 """

 def test_func(self):
 if self.request.user.onboarded and self.request.user.is_active:
 return True

 def get_login_url(self):
 return redirect('onboarding',)

Rather than taking this approach, maybe its best to use a decorator instead. For example:

from django.contrib.auth.decorators import login_required

def my_login_required(function):
 def wrapper(obj, request, *args, **kw):
 decorated_view_func = login_required(request)
 if not decorated_view_func.user.is_authenticated:
 return decorated_view_func(request) # restricts without login and sends to signin view

 if request.user.onboarded and request.user.is_active:
 return function(obj, request, *args, **kw)
 return HttpResponseRedirect("/onboarding/")

 return wrapper

And use this decorator in desired views:

 class SomeView(DetailView):
 ...

 @my_login_requried
 def dispatch(self, *args, **kwargs):
 return super(SomeView, self).dispatch(*args, **kwargs)